main: add more fiat currencies, deprecate kraken api - #4592
Open
SNeedlewoods wants to merge 1 commit into
Open
Conversation
SNeedlewoods
force-pushed
the
jpk68_add_more_fiat_currencies_remove_kraken_api
branch
from
July 9, 2026 11:11
ec26ceb to
a3c2ccb
Compare
Contributor
SChernykh
reviewed
Aug 4, 2026
| } | ||
|
|
||
| function getKeyFromCurrency(currency) { | ||
| switch (currency) { |
Contributor
There was a problem hiding this comment.
It's better to check the length, check the first 3 letters and return the last 3 letters. Then it will be universal and not depend on the set of supported currencies.
SChernykh
reviewed
Aug 4, 2026
| "xmrcad": "https://api.coingecko.com/api/v3/simple/price?ids=monero&vs_currencies=cad", | ||
| "xmraud": "https://api.coingecko.com/api/v3/simple/price?ids=monero&vs_currencies=aud", | ||
| "xmrnzd": "https://api.coingecko.com/api/v3/simple/price?ids=monero&vs_currencies=nzd", | ||
| "xmrchf": "https://api.coingecko.com/api/v3/simple/price?ids=monero&vs_currencies=chf" |
Contributor
There was a problem hiding this comment.
To avoid copy-paste errors, it's better to use getKeyFromCurrency and construct the url from its template.
SChernykh
reviewed
Aug 4, 2026
| "xmrcad": "https://min-api.cryptocompare.com/data/price?fsym=XMR&tsyms=CAD", | ||
| "xmraud": "https://min-api.cryptocompare.com/data/price?fsym=XMR&tsyms=AUD", | ||
| "xmrnzd": "https://min-api.cryptocompare.com/data/price?fsym=XMR&tsyms=NZD", | ||
| "xmrchf": "https://min-api.cryptocompare.com/data/price?fsym=XMR&tsyms=CHF" |
Contributor
There was a problem hiding this comment.
Same, getKeyFromCurrency and construct the url from template.
SNeedlewoods
force-pushed
the
jpk68_add_more_fiat_currencies_remove_kraken_api
branch
from
August 5, 2026 17:40
a3c2ccb to
66975e9
Compare
Contributor
|
@SChernykh Thanks for your comments; they have all been resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
submitted by jpk68
https://codeberg.org/jpk68/monero-gui/pulls/3
(I have not reviewed this code, merely forwarding it)